 |
|
Maquiladora
|
|
Has anyone found any references to it yet? Particularly why the turn doesnt end.
|
|
| |
|
|
|
Maquiladora
|
|
OK, IIRC its when you end turn it goes to the black screen and asks to close or exit (i think) and saves the turn to desktop, this is all normal, but when youve played all turns of all players and it goes back to player 1's turn, the turn still says "Turn 0" and all production/science/food whatever hasnt been collected and all player moves moved in the last turn are still exhausted, basically the turn hasnt ended but it goes around the player order.
|
|
| |
|
|
|
J Bytheway
|
 |
England
Jul 2001
time: 05:31
|
|
Well, I think I've found the source of the problem, at least.
Essentially, in CTP1 the dialog asking you to forward the turn didn't pop up until after the next players turn had already begun, and all his start-of-turn stuff had been processed. This led to problems, because you could determine information about his empire by the kind of messages he was receiving and also what gold, PW and population he had.
It seems that they have moved the save game time forward now so that the game advances the player, and then the save occurs before any of the start-of-turn stuff happens.
Presumably, when you load the game it doesn't realise that it still has the start-of-turn stuff to do. I haven't investigated that yet. I am reminded, however, that when you play scenarios it does that start-of-turn stuff every time you load regardless, and so perhaps they shifted the code which should have been for the PBEM to the scenario stuff instead...
Something that does concern me a little is that just before it does the PBEM save it sets g_isScenario = false, and so I suspect PBEM forgets when you try to play it with a scenario. Of course, noone uses scenarios at the moment because they're broken, but I'm hoping that will change.
|
|
| |
|
|
|
J Bytheway
|
|
England
Jul 2001
time: 05:31
|
|
Well, I've been unable to come up with anything better, so the fixes are at:
http://apolyton.net/csd.php?http://...ay/Pbem_bug.zip
These are to replace gs/utilities/newturncount.cpp and gs/gameobj/PlayerEvent.cpp. Essentially, I cut out the code that saves the game and pops up the messagebox from where it was, which was during the BeginTurn event handling before everything had happened, and I've put it in the FinishBeginTurn event, where almost everything has happened.
Last edited by J Bytheway on 08-11-2003 at 20:02
|
|
| |
|
|
|
Maquiladora
|
|
Does that also mean the Diplomacy carries over to the next players turn too, like it should? The problem was you would give a proposal to a human player and it would disappear on his turn.
|
|
| |
|
|
|
Maquiladora
|
|
I found these posts from Pyaray aaaages ago...
quote:
We do know exactly what is causing the bug. And we know for a fact that it won't creep into other game modes. It is specifically related to events occuring when it is the "wrong" persons turn, and causing problems. In both single player, and net play, the "right" person is always available and therefore eliminates the problem.
Pyaray |
quote:
Well, other things being rewritten affected it. As I mentioned in another post, it has to do with events occuring when it's not the appropriate players turn. There is logic to not give messages to the wrong players, yet the game expects answers to some messages prior to allowing it to continue. So you get in this stuck position where it won't procede without an answer, but it can't ask the question cause it's not their turn. This may sound like a very simple thing, but believe me, it's not. And for everyones knowledge, Hot Seat, and PBEM pretty much use the same logic. |
Lots of people moaning because theyd be no PBEM...
http://apolyton.net/forums/Forum35/HTML/000287.html
|
|
| |
|
|
|
Maquiladora
|
|
Okay ill post what ive seen having tested with the zip kaan made.
Scenario #1
Eight Players
1 - Maq
2 - Maq2
3 - AI
4 - AI
5 - AI
6 - AI
7 - AI
8 - AI
I put in the names and emails so i know whos it is, i press ok and it loads up the game then immediately saves the game without letting me even see where i am and gives the option to "quit" or "close", meaning it saved before I, as human player 1 (Maq) could play my turn.
It saves a turn on my desktop "CTP Email To maq@maq.com (Turn 0).c2g", i double-click and it loads and its "Maq" Player 1's civ's turn, all movement intact. I play the turn as normal and end it.
It saves the turn on my desktop, "CTP Email To maq2@maq2.com (Turn 0).c2g", okay player 2's turn "Maq2", i double-click it, it should be turn 0 for Maq2, but its turn 1... so Maq2 has missed his Turn 0 somehow....
It saves "CTP Email To maq@maq.com" on my desktop i double-click it loads and its "Maq's" (Player 1) Turn 1..... so now Maq2 has become "Player 1" and Maq is "Player 2", but they keep their original colours obviously (Maq2 is orange still but takes his turn before Player 1!)
(Ignore the file naming when it sends it to my desktop, its always "Turn 0")
I assume you got similar mixed results J Bytheway?
It does work normally after that though, production, science and food is processed as it should, which has been fixed then.
Last edited by Maquiladora on 12-12-2003 at 01:02
|
|
| |
|
|
|
J Bytheway
|
|
England
Jul 2001
time: 05:31
|
|
quote:
Originally posted by Maquiladora
Okay ill post what ive seen having tested with the zip kaan made.
Scenario #1
Eight Players
1 - Maq
2 - Maq2
3 - AI
4 - AI
5 - AI
6 - AI
7 - AI
8 - AI
I put in the names and emails so i know whos it is, i press ok and it loads up the game then immediately saves the game without letting me even see where i am and gives the option to "quit" or "close", meaning it saved before I, as human player 1 (Maq) could play my turn. |
Yes, that's because I moved the code that pops up the dialog from the end of the turn to the beginning.
quote:
It saves a turn on my desktop "CTP Email To maq@maq.com (Turn 0).c2g", i double-click and it loads and its "Maq" Player 1's civ's turn, all movement intact. I play the turn as normal and end it.
It saves the turn on my desktop, "CTP Email To maq2@maq2.com (Turn 0).c2g", okay player 2's turn "Maq2", i double-click it, it should be turn 0 for Maq2, but its turn 1... so Maq2 has missed his Turn 0 somehow....
It saves "CTP Email To maq@maq.com" on my desktop i double-click it loads and its "Maq's" (Player 1) Turn 1..... so now Maq2 has become "Player 1" and Maq is "Player 2", but they keep their original colours obviously (Maq2 is orange still but takes his turn before Player 1!)
(Ignore the file naming when it sends it to my desktop, its always "Turn 0")
I assume you got similar mixed results J Bytheway? |
Yes - although I didn't test it much more than you have on the latest version. As I said, strange things started happening when I did Human-Human diplomacy.
quote:
It does work normally after that though, production, science and food is processed as it should, which has been fixed then. |
I see you were getting turn numbers advancing - mine was always stuck on turn 0. I guess that's because you had an AI player playing last, whereas mine were all human players.
|
|
| |
|
|
|
Maquiladora
|
|
It was a short but enjoyable game, ill gladly hand you your ass on a plate again, anytime.  
J has made a fix of actually making it "complete" the turns, collecting resources, resetting move points, advancing science, production builds etc, im not sure how much of a permanent fix this is, although it does the job, it mixes up the first turn order (read above posts) this needs more tests though perhaps.
So if youre giving it a test, use all Human players, seeing as that is the most important to get working really.
|
|
| |
All times are GMT. The time now is 05:31.
Apolyton Time is 00:31. |
top of page
|
|
|
Forum Rules:
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
|
HTML code is ON
vB code is ON
Smilies are ON
[IMG] code is ON
|
|
|
|
|
|
01-11-2003 22:15
.
okdat dont worry im still reading your prodress j although i cant help at all really epecially when im a little drunk
|