04-11-2003 04:42									#1
	The only one ConstructionTile used bug Support Apolyton buy from Amazon

If you ever played around with the ContructionTiles flags in tileimp.txt then you noticed that unlike in CTP1 only one of the three ContructionTiles is used instead of three. While I was trying to fix it I found another bug, the PercentComplete function in TerrImproveData.cpp:

code:

sint32 TerrainImprovementData::PercentComplete() const
{
	sint32 totalTurns, turnsDone;

	MapPoint p = m_point;
	//Function replaced by Martin Gühmann
	//Original function always returns 10 instead of the total production turns.
//	totalTurns = terrainutil_GetTimeToBuild(p, m_type, m_transformType);
	totalTurns = terrainutil_GetProductionTime(m_type, p, m_transformType);
	turnsDone = totalTurns - m_turnsToComplete;
	if (totalTurns == 0) return 100;
	return (turnsDone * 100) / totalTurns;
}

code:

void  TiledMap:rawPartiallyConstructedImprovement(aui_
Surface *surface, uint32 env, sint32 type, sint32 x, sint32 y, uint16 index, BOOL fog, sint32 percentComplete)
//Added sint32 percentComplete by Martin Gühmann
{
//....
	const TerrainImprovementRecord *rec = g_theTerrainImprovementDB->Get(type);
/*	//MG: Origianal code outcommented and replaced by the code below
	if(index >= rec->GetNumConstructionTiles()) {
		if(rec->GetNumConstructionTiles() < 1) {
			data = m_tileSet->GetImprovementData(1);
		} else {
			data = m_tileSet->GetImprovementData((uint16) rec->GetConstructionTiles(rec->GetNumConstructionTiles() - 1));
		}
	} else {
		data =  m_tileSet->GetImprovementData((uint16) rec->GetConstructionTiles(index));
	}*/
	if(rec->GetNumConstructionTiles() < 1) {
		data = m_tileSet->GetImprovementData(1);
	}
//	else if(rec->GetNumConstructionTiles() < 2) {
//		data = m_tileSet->GetImprovementData((uint16) rec->GetConstructionTiles(rec->GetNumConstructionTiles() - 1));
//	} 
	else {
		uint16 ctIndex = (uint16)floor((rec->GetNumConstructionTiles() * percentComplete)/100 );
		data = m_tileSet->GetImprovementData((uint16) rec->GetConstructionTiles(ctIndex));
	//	Original code:
	//	data = m_tileSet->GetImprovementData((uint16) rec->GetConstructionTiles(index));
	}
//....
}

Attachment: tileimp.zip
This has been downloaded 4 time(s).

	06-11-2003 22:16									#2
	Re: The only one ConstructionTile used bug Increase the size of your Attachments

quote: Originally posted by Martin Gühmann Unfortunatly while I was steting this code in the debug build I got much more Assertion failure messages then before. I think I have tested my last modification and the rush build fix with it but I am not sure at 100%.

I figuered out why I got more debug assertions: I switched to GoodMod of course without its slic files, so finally we have also to test the game on mods.

-Martin

	07-11-2003 23:53									#3
	Inflate your Upload Space

Hi Martin,
You mention you can only see the partially constructed improvement if a unit can see it and not if it is just within your city radius. Is this also true of any ordinary improvement you own? For instance, if someone comes and pillages a tile improvement in your city radius, do you not see it? Do you think that this is a problem?

	08-11-2003 00:00									#4
	Support Apolyton, buy GURPS/ Alpha Centauri

No it is just a problem of not finished tile improvements that their graphics are only updated when you enable good mode or one of your units is moving near the not finished tile improvement.

-Martin

	08-11-2003 02:44									#5
	Support Apolyton, buy Galactic Civilizations

I guess I meant whether or not you think we should change the display behaviour of title improvements. This is controlled by tiledraw.cpp, we can change it if you think it appropriate.

	08-11-2003 04:06									#6
	Support Apolyton, buy Call to Power 2

I already changed the display behaviour for unfinished tile improvements, because this way it comes closer to the CTP1 display behaviour of unfinished tile improvements. The problem is that I don't know where the part of the function is located were the unfinished tile improvements are updated. For finished improvements there is no need to update them every turn, because they don't change their graphics every or every second turn like for the unfinished tile improvemnts. So I think the problem is that this draw function isn't recalled every turn. Of course the is no need for it, as long as nothing changes. I guess the programmers just forgot the construction tiles, because they give them all the same graphics.

-Martin