23-04-2004 02:41									#181
	Support Apolyton, buy Civilization 2

I took it to mean that it improves 100% worked rings before the partial worked outer ring - but you are right Maq it is not clear what the change does.

	23-04-2004 02:48									#182
	Lose 30 kilos (of popups)

When generating a list of candidate tile improvements, each candidate is assigned a value (utility) based on the terrain, improvement, and city properties.

I have now multiplied this utility value with the worker utilisation percentage applied to the tile when determining the city production.

So when you have a size 7 city: the 8 inner ring tiles have unmodified utility values (100% utilisation - for some reason the game requires only 6 workers to make the first ring being 100% ), while the second ring has a reduced utility value (IIRC it is (7 - 6) / (18 - 6) = 1/12 = 8.3%), which will go up when the city grows.

After generating the list, it will be ordered on descending utillity value, and PW spending will start from the beginning of the list. So, there is no fixed % where you don't work a tile. But it will prevent spending PW on improvements that are not really contributing.

So, Flinx was correct.

I think this is a forgotten issue from the CTP1 to CTP2 conversion. In CTP1, a placed worker meant 100% utilisation, regardless of the distance of the tile to the city or the number of available workers.

	23-04-2004 03:02									#183
	Support Apolyton, buy Civilization: The Boardgame

quote: for some reason the game requires only 6 workers to make the first ring being 100%

Isnt that because of the city size 1-6 for inner ring, 7-18 (12) for second ring etc. but i thought that could be changed in citysize*.txt so why is it hardcoded?

	23-04-2004 04:39									#184
	Increase Your PM Length

Fromafar you did use the variables loaded from citysize*.txt didn't you?
I made a mod which changes these files and I would like it if your improvement worked correctly with the mod.

	27-04-2004 22:44									#185
	Suffering from ads?

2004.04.27
..\ctp2_code\gs\gameobj\gaiacontroller.cpp

Bug Fix by Martin Gühmann: Neutral pillage tile improvement bug, the game doesn't crash anymore when a tile improvement is pillaged that noone owns.

-Martin

Attachment: 2004.04.27.gaiacontroller.incr.zip
This has been downloaded 6 time(s).

	01-05-2004 01:00									#186
	Lose 30 kilos (of popups)

2004.04.30
..\ctp2_code\gs\slic\SlicFrame.cpp
..\ctp2_code\gs\slic\slicif.cpp

Games that uses slic database access can now be reloaded without the need to /reloadslic to prevent a crash, unfortunatly this applies only to games that are saved with this version of the slic database access, games saved with Activision's patch v.1.1 and with slic code that uses database access may not be continued without a /reloadslic.

-Martin

Attachment: 2004.04.30.slicdbaccess.incr.zip
This has been downloaded 8 time(s).

	01-05-2004 02:27									#187
	Inflate your Upload Space

2004.04.30
..\ctp2_code\ctp\civapp.cpp

Bug fix by Martin Gühmann: A memory leak that occured in the Great Libary when a saved game was loaded, only regular saves with the ranking and world map *.rim, not the quicksave.

-Martin

Attachment: 2004.04.30.glleak.fix.zip
This has been downloaded 7 time(s).

	09-05-2004 00:23									#188
	Support Apolyton or Terrorists Win

User profile option + repaired memory leaks.

ui\interface\GreatLibrary.cpp
Repaired more memory leaks that were caused by reloading the great library data.

gs\database\ProfileDB.cpp
gs\database\ProfileDB.h
ctp\civapp.cpp
Added a "ColorSet" option to userprofile.txt, to make variation between the colors##.txt files easier.

Note: I undid some previous changes by Martin in civapp.cpp. Those were no longer needed now that the great library memory leaks have been repaired at the root.

OT/late reply: the tile improvement placement change has no impact on how many workers are in a ring. The citysize#.txt values are being used - nothing is hardcoded.

[Edit: link removed. Included in the 2004.06.05 source collection.]

Last edited by Fromafar on 13-06-2004 at 19:34

	09-05-2004 23:56									#189
	Support Apolyton, buy Civilization: The Boardgame

Bug fix: tile improvements without Freight cost modification no longer have 0 Freight cost for the trade route computation. This should prevent funny paths from being computed.

gs\newdb\terrimprove.cdb
gs\world\cell.cpp
[Edit: link removed. Included in the 2004.06.05 source collection.]

Last edited by Fromafar on 13-06-2004 at 19:35

	15-05-2004 22:34									#190
	Increase the size of your Attachments

Bug fixes

gs\newdb\CTPDatabase.cpp
gs\newdb\CTPDatabase.h
Repaired memory leaks and cleaned up the government modification code somewhat.

ui\interface\sci_advancescreen.cpp
(Activision patch 1.1 reimplementation) Start the "change research" screen with the current research selected.

[Edit: link removed. Included in the 2004.06.05 source collection.]

Last edited by Fromafar on 13-06-2004 at 19:37

	16-05-2004 21:48									#191
	Support Apolyton, buy Civilization III: Complete

Bug fix:

gs\gamedata\ArmyData.cpp
(Activision patch 1.1 reimplementation) Corrected a check that prevented sueing of franchises.

[Edit: link removed. Included in the 2004.06.05 source collection.]

Last edited by Fromafar on 13-06-2004 at 19:37

	17-05-2004 01:45									#192
	Support Apolyton, pre-order Civilization IV

Well Fromafar, with the use of the STL for the government stuff I get now these warnings, is there a way to disable them?

quote: c:\programme\microsoft visual studio\vc98\include\vector(39) : warning C4786: 'std::reverse_iterator >::iterator const *,std::list >::iterator,std::list >::iterator const &,std::list >::iterator const *,int>' : Bezeichner wurde auf '255' Zeichen in den Debug-Informationen reduziert c:\programme\microsoft visual studio\vc98\include\vector(39) : Bei der Kompilierung der Member-Funktion '__thiscall std::vector >::iterator,dbgallocator >::iterator> >::std::vector >::iterator,dbgallocator >::iterator> >(const dbgallocator >::iterator> &)' der Klassenvorlage c:\programme\microsoft visual studio\vc98\include\vector(39) : warning C4786: 'std::reverse_iterator >::iterator *,std::list >::iterator,std::list >::iterator &,std::list >::iterator *,int>' : Bezeichner wurde auf '255' Zeichen in den Debug-Informationen reduziert c:\programme\microsoft visual studio\vc98\include\vector(39) : Bei der Kompilierung der Member-Funktion '__thiscall std::vector >::iterator,dbgallocator >::iterator> >::std::vector >::iterator,dbgallocator >::iterator> >(const dbgallocator >::iterator> &)' der Klassenvorlage c:\programme\microsoft visual studio\vc98\include\vector(39) : warning C4786: 'std::vector >::iterator,dbgallocator >::iterator> >::vector >::iterator,dbgallocator >::iterator> >' : Bezeichner wurde auf '255' Zeichen in den Debug-Informationen verkürzt c:\programme\microsoft visual studio\vc98\include\vector(60) : warning C4786: 'std::vector >::iterator,dbgallocator >::iterator> >::~vector >::iterator,dbgallocator >::iterator> >' : Bezeichner wurde auf '255' Zeichen in den Debug-Informationen verkürzt c:\programme\microsoft visual studio\vc98\include\vector(52) : warning C4786: 'std::vector >::iterator,dbgallocator >::iterator> >::vector >::iterator,dbgallocator >::iterator> >' : Bezeichner wurde auf '255' Zeichen in den Debug-Informationen verkürzt

-Martin

	18-05-2004 00:17									#193
	Support Apolyton, pre-order Civilization IV

To suppress this warning, you may add a

code:
#pragma warning(disable: 4786)

	18-05-2004 01:28									#194
	Support Apolyton, pre-order Civilization IV

Not that i understand much of what is happening here - but whatever it is it's appriciated

	18-05-2004 01:34									#195
	Support Apolyton, pre-order Civilization IV

Is there a good reason why those warnings can't be eliminated by altering the code?

	18-05-2004 02:11									#196
	Support Apolyton, pre-order Civilization IV

The reason is that the 'offending' piece of code is part of the compiler, and not of the Activision code.

Because of that, this warning does not really apply to us. It merely states (roughly translated from German) that the compiler has generated some symbols that contain more than 255 characters, and that for debugging purposes it has truncated these symbols to 255 characters.

As this is a piece of code that we are not going to modify at all, debugging it is not very interesting. And even with 'only' 255 characters, you probably would be able to find the correct symbol.

	18-05-2004 02:14									#197
	Support Apolyton buy from Amazon

quote: Originally posted by Fromafar The reason is that the 'offending' piece of code is part of the compiler, and not of the Activision code.

Ah yes. I didn't notice that. Silly me.

	18-05-2004 02:31									#198
	Keep up the good work guys! Support Apolyton, buy Civilization 2

Did anyone look at the TEST/DEBUG: Slic built-in data accessors files? If these work maybe we could get a new playtest

	18-05-2004 02:36									#199
	Help yourself to an AD-FREE life

I was seriously considering releasing a new "official" playtest version incorporating them - I think that's the only way we'll get them tested...

	18-05-2004 03:50									#200
	Avatar Enlargement: We've got the solution

Go for it I am always reedy to play test.

	18-05-2004 05:36									#201
	Support Apolyton, buy Alpha Centauri

quote: code:--------------------------------------------------------------------------------#pragma warning(disable: 4786)--------------------------------------------------------------------------------

warning 4786 is very common when using STL containers, especially maps and sets. As FROMAFAR stated it is a truncation warning that can be safely ignored. Every time a container copies itself internally during code generation, it generates a unique name by concatenation and quickly surpasses the 255 char limit. At least this is the explanation I was given when we began studying STL containers this semester.

In Project->Settings [c/c++ tab, general category] you can set the warning level to NONE but it normally only reduces the number of warnings issued from hundreds to dozens.

Or you can use the #pragma in affected files, but note that

quote: From MSDN VC++6 documentation: For warning numbers greater than 4699, those associated with code generation, the warning pragma has effect only when placed outside function definitions. The pragma is ignored if it specifies a number greater than 4699 and is used inside a function. The following example illustrates the correct placement of warning pragmas to disable, and then restore, the generation of a code-generation warning message: int a; #pragma warning( disable : 4705 ) void func() { a; } #pragma warning( default : 4705 )

	18-05-2004 20:36									#202
	Support Apolyton buy from Amazon

The Great Library entry for Hospital is incorrect as I posted over in CTP2 Mods. The section of Great_Library.txt should read:

code:
[IMPROVE_HOSPITAL_STATISTICS]
Gives:
Reduces <L: DATABASE_CONCEPTS,CONCEPT_OVERCROWDING>Overcrowding<e> Effect by {BuildingDB(Building[0]).RaiseOvercrowdingLevel}
[END]

	19-05-2004 02:59									#203
	Put an end to popups!

Activision patch reimplementation:

gs\gameobj\GameSettings.cpp
Use the difficulty and barbarian risk level as selected by the user when starting a new (scenario) game.

[Edit: link removed. Included in the 2004.06.05 source collection.]

Last edited by Fromafar on 13-06-2004 at 19:40

	19-05-2004 15:46									#204
	Inflate your Upload Space

quote: Originally posted by Flinx The Great Library entry for Hospital is incorrect

I'm not sure what our approach towards errors in the text is at the moment. Probably its best to post about them in the translation centre, because they might be present in other languages too...

	19-05-2004 15:49									#205
	Support Apolyton, buy Civilization: The Boardgame

I get the error:

code:
F:\Games\CTP2Src2\ctp2_code\gs\world\Cell.cpp(962) : error C2660: 'GetFreight' : function does not take 1 parameters

	19-05-2004 16:54									#206
	Support Apolyton, buy Galactic Civilizations: Deluxe Edition

This error may occur when the TerrainImprovementRecord.h and .cpp files have not been updated from the terrimprove.cdb input.

Did you do a debug build first? IIRC some of the custom build steps are not executed properly in the other builds.

	19-05-2004 17:53									#207
	Support Apolyton buy from Amazon

quote: Originally posted by Flinx The Great Library entry for Hospital is incorrect as I posted over in CTP2 Mods. The section of Great_Library.txt should read: code: [IMPROVE_HOSPITAL_STATISTICS] Gives: Reduces <L: DATABASE_CONCEPTS,CONCEPT_OVERCROWDING>Overcrowding<e> Effect by {BuildingDB(Building[0]).RaiseOvercrowdingLevel} [END] It should be the same as the entry for Incubation Center which follows it.

Well and what does it say originally.

quote: Originally posted by Fromafar This error may occur when the TerrainImprovementRecord.h and .cpp files have not been updated from the terrimprove.cdb input. Did you do a debug build first? IIRC some of the custom build steps are not executed properly in the other builds.

Another problem with this database generator is that it does not regenerate all the files if it is necessary for instance I modified the RecordDescription.cpp that should have as consequence that all the generated files have to be regenerated, but at university a lot of files were not regenerated and it home same modification two files a header file and the according implemention file were not regenerated.

-Martin

	19-05-2004 17:55									#208
	Suffering from ads?

quote: Originally posted by Fromafar This error may occur when the TerrainImprovementRecord.h and .cpp files have not been updated from the terrimprove.cdb input. Did you do a debug build first? IIRC some of the custom build steps are not executed properly in the other builds.

That would explain it. Thanks. I'll try a debug build now.

	19-05-2004 19:08									#209
	Support Apolyton, buy Civilization 2

Yep, that worked. Thanks again.

	19-05-2004 20:03									#210
	Increase the size of your Attachments

quote: Originally posted by Martin Gühmann Well and what does it say originally.

In the English version:

code:
[IMPROVE_HOSPITAL_STATISTICS]
Gives:
Increases City Max Size
Reduces <L: DATABASE_CONCEPTS,CONCEPT_OVERCROWDING>Overcrowding<e> Effect by {BuildingDB(Building[0]).RaiseMaxPopulation}
[END]