23-12-2004 11:00									#1
	Design: New SLIC functions Increase Your PM Length

I'll track any requests that people post here and put it in the first thread.

Some suggestions first



2) More access to adding tabs, windows, buttons instead of just message boxes (it may be tough though)

3) AddSlave (and Add Specialists) (BigMC)

4) ChangeCivilizationName

6) Change City Style

7) AddFood

8) AddScience




I'm not a SLICmaster but from what I've seen these aren't available. I'm sure those familiar with SLIC can think of a lot more.


Some deleted after Martin bashed me for my ignorance

Last edited by E on 24-12-2004 at 04:51

	23-12-2004 21:10									#2
	Support Apolyton or Terrorists Win

What would AddFood and AddScience be? Add one-time to a city, or add per-turn to city, or add percentage per-turn to all cities? Many options .

	24-12-2004 02:10									#3
	Re: Design: New SLIC functions Support Apolyton buy from Amazon

quote: Originally posted by E 1) GetGovernment (although MartinG says it can be done now)

int0 = player[0].government;
int1 = player[0].govttype;

Do the job, of course player[0] must be filled with a player and int0 and int1 conatain after the code execution the same integer values.

quote: Originally posted by E 3) add slave function (Big MC)

code:

HandleEvent(CityClicked)'MG_TestingH'post{
	Event:MakePop(city[0], 2);
}

	24-12-2004 04:24									#4
	Increase Your PM Length

martin i get ( and always have had) an error saying wrong number of arguments.

	24-12-2004 04:32									#5
	Tired of ads?

quote: Originally posted by The Big Mc martin i get ( and always have had) an error saying wrong number of arguments.

Yes, I get it as well, and that is a problem if you want to use it in a mod, but nevertheless the code above adds a slave to a city whenever you click it. I did not claim that it works fine. To be precise I got the suspicion that all events with optional arguments do not work as advertized, you can call them within the source code but not from slic without slic errors and asserts in the debug version.

-Martin

	24-12-2004 04:42									#6
	Support Apolyton, pre-order Civilization IV

Well maybe we should go with a seperate AddSlave function or overload the add pop function (adding a pop type argument), at least that is much easier to do then to find this nasty bug and an overloaded AddPop function would have the benefit of being able to add other speacialists too.

-Martin

	24-12-2004 05:58									#7
	Put an end to popups!

Just looked at CityData.cpp, it does have the nice ChangeSpecialists function that takes a POP_TYPE argument and an int argument, so indeed, an overloaded function adding any type of pop is good.

	30-12-2004 05:14									#8
	Tired of ads?

How about a way to prevent city from growing(as in the 1000 value not the map value.)

	01-01-2005 19:58									#9
	Increase the size of your Attachments

What do you mean, in the 1000 value?

	02-01-2005 05:07									#10
	Suffering from ads?

You know the empire size in empire manager. Well according to that on a occ a city grows in population and it's this population you feed not the city size as seen on the map.

I know you can stop growth using a event (cityaddpop) code but I don’t know a way to change the value in empire manager.
.

	05-01-2005 23:47									#11
	Support Apolyton, buy Civilization III: Complete

this is kind of relaed to SLIC, but I wondering how hard it would be to add in the source code a scroll bar (or something similar) to where the unit action buttons are (disband, settle, etc) and make it so modders can add buttons that have slic effects.

I know some slic uses the disband or sentry buttons to cause events (like upgrade) but it would be great if a modder could add new buttons (like upgrade or raze or enslave city) so that a lot of ctp2 changes requests can be done via slic instead of in the code.

	06-01-2005 03:42									#12
	Support Apolyton buy from Amazon

1/ The 'other four' mod_* functions made int_f rather than bool_f

2/ Increased trade access: RouteCreated and RouteBroken events would be the minimum I guess, with players and good type arguments. IsPlayerTradingGood would be best Possibly a player array variable numberofroutes or something as well. There are probably others that would help, especially if anyone does want to put in the effort for Civ3esque resources.

3/ Slavery access: AddSlave yes, and RemoveSlave (or ConvertPopToSlave and ConvertSlaveToPop even) would be great for scenarios and testing, if not in a normal (modded) game.

4/ Fix ContinentBiggerThan if not already done, although to be honest IsOnSameContinent and ContinentSize functions would be more useful.

	07-01-2005 02:07									#13
	Support Apolyton, pre-order Civilization IV

A long time ago I had an optimistic idea which I don't think I ever posted about.

I thought that it would be nice to allow some kind of Mayor-like function which would be implemented entirely through SLIC. I know that when I am building I often do it in a very formulaic fashion which it would be easy to formalize. Since it would be easily tweakable by many, in the long term, this could result in very effective (or at least, much better than the existing) mayoral behaviour which could then be used to rewrite the existing AI.

	11-01-2005 03:26									#14
	Support Apolyton, buy Civilization: The Boardgame

quote: Originally posted by Immortal Wombat 4/ Fix ContinentBiggerThan if not already done, although to be honest IsOnSameContinent and ContinentSize functions would be more useful.

For IsOnSameContinent what about : GetContinent(location[0]) == GetContinent(location[1])

That's already in the code.

-Martin

	11-01-2005 23:15									#15
	Full PM-box? Change here!

Is there a source code map out some were I need to find where the slic functions are held.

	11-01-2005 23:32									#16
	Support Apolyton, buy Civilization III: Complete

quote: Originally posted by The Big Mc Is there a source code map out some were I need to find where the slic functions are held.

What about ..\ctp2_code\gs\slic\ and there slicfunc.h, slicfunc.cpp, slicfuncai.h and slicfuncai.cpp. Or what about using your OS file search engine to look for files with the extension *.cpp and *.h which contain for instance the string GetContinent.

By the way if you like to do some practice you can do this IsOnSameContinent function all the ingredients you need should be in the GetContinent function.

-Martin

	11-01-2005 23:59									#17
	Support Apolyton, buy Call to Power 2

bigmc I hope you've taken up the task to bring in new slic functions, it will be appreciated.

	12-01-2005 01:42									#18
	Support Apolyton, buy Civilization 2

Alright, if you wanted IsOnSameContinent, here you go.

Usage: IsOnSameContinent (pos1, pos2)

Returns 1 if both squares are on the same continent, and 0 otherwise.

Attachment: slic_samecontinent.rar
This has been downloaded 2 time(s).

	12-01-2005 01:53									#19
	Support Apolyton buy from Amazon

quote: Originally posted by Immortal Wombat 2/ Increased trade access: RouteCreated and RouteBroken events would be the minimum I guess, with players and good type arguments. IsPlayerTradingGood would be best Possibly a player array variable numberofroutes or something as well. There are probably others that would help, especially if anyone does want to put in the effort for Civ3esque resources.

I found this bit of code. I think it might be the start of something that IM was talking about

code:
  slicfunc.cpp 
SFN_ERROR Slic_TradePoints::Call(SlicArgList *args)
{
	sint32 p;

	if(args->m_numArgs != 1)
		return SFN_ERROR_NUM_ARGS;

	if(!args->GetPlayer(0, p)) {
		return SFN_ERROR_TYPE_ARGS;
	}

	m_result.m_int = g_player[p]->m_tradeTransportPoints;
	return SFN_ERROR_OK;
}

SFN_ERROR Slic_TradePointsInUse::Call(SlicArgList *args)
{
	sint32 p;

	if(args->m_numArgs != 1)
		return SFN_ERROR_NUM_ARGS;

	if(!args->GetPlayer(0, p)) {
		return SFN_ERROR_TYPE_ARGS;
	}

	m_result.m_int = g_player[p]->m_usedTradeTransportPoints; 
	return SFN_ERROR_OK;
}

SFN_ERROR Slic_TradeRoutes::Call(SlicArgList *args)
{
	sint32 p;
	if(args->m_numArgs != 1)
		return SFN_ERROR_NUM_ARGS;

	if(!args->GetPlayer(0, p)) {
		return SFN_ERROR_TYPE_ARGS;
	}
	
	m_result.m_int = g_player[p]->GetNumTradeRoutes();
	return SFN_ERROR_OK;
}

SFN_ERROR Slic_HasSameGoodAsTraded::Call(SlicArgList *args)
{
	sint32 p;
	if(args->m_numArgs != 1)
		return SFN_ERROR_NUM_ARGS;
	if(!args->GetPlayer(0, p))
		return SFN_ERROR_TYPE_ARGS;

	m_result.m_int = g_player[p]->HasSameGoodAsTraded();
	return SFN_ERROR_OK;
}

	12-01-2005 02:11									#20
	Got spare money?

Well that wasn't so difficuilt, let's set up something that can be more called as a challenge for training purposes of course.

Extendet trade acces. A function that returns the number of trade route at a specific location. The syntax would be like this:

int_t TradeRoutes(location_t)

Some other trade specifix functions would be:

void_t GetTradeRouteByIndex(location_t, int_t, traderoute_t)

First parameter the location that contains a trade route, second an index and third a parameter that is filled with a specific trade route. The only little problem with this is that we have no traderoute_t thing that has to be implemented. And this is necessary to allow the trade route specific events called from slic.

void_t GetTradePartners(traderoute_t, city_t, city_t)

With the traderoute_t thing we coult retrive from it the start and endpoint of a trade route.

int_t GetTradeGood(traderoute_t)

Get the index of the good that is traded by the give route.

The first function shouldn't be too difficuilt, maybe not all indrigents are found in the slicfunc.cpp, but Cell.cpp and Cell.h should help you.

For fixing ContinentBiggerThan I have no idea it is somewhere in the underlying functions outside slic, by the way what in particular does not work about this function, what are the symptoms?

-Martin

	12-01-2005 02:39									#21
	Support Apolyton buy from Amazon

Qualifying to be a C++ teacher now, Martin ?

	12-01-2005 02:48									#22
	Support Apolyton, buy Galactic Civilizations

quote: Originally posted by Solver Qualifying to be a C++ teacher now, Martin ?

We need some more coders don't we.

-Martin

	12-01-2005 02:57									#23
	Support Apolyton, buy Galactic Civilizations

if your patient I'm willing to learn...

Should we also have:

PlayerReceivesTradedGood function?

PlayerSendstradedGood function?


I'm just thinking of possible options like IW said to make it easier to replicate civ3 good trading so we can stop getting that question asked.


as for the new code, do we need to type something like this?

code:

int_t TradeRoutes(location_t)
{
	sint32 p;
	if(args->m_numArgs != 1)
		return SFN_ERROR_NUM_ARGS;
	if(!args->GetPlayer(0, p))
		return SFN_ERROR_TYPE_ARGS;

	m_result.m_int = g_player[p]->TradeRoutes();
	return SFN_ERROR_OK;
}

	12-01-2005 03:23									#24
	Increase Your PM Length

code:
SFN_ERROR Slic_Addslaves::Call(SlicArgList *args)
{
	if(args->m_numArgs != 2)
		return SFN_ERROR_NUM_ARGS;
	Unit city;
	BOOL res;

	res = args->GetCity(0, city);
	if(!res) {
		return SFN_ERROR_TYPE_ARGS;
	}

	sint32 count;
	if(!args->GetInt(1, count))
		return SFN_ERROR_TYPE_ARGS;

	MapPoint pos; 
	city.GetPos(pos);
	
	sint32 i;
	if(count > 0) {
		for (i=0; iAddEvent(GEV_INSERT_Tail, GEV_MakePop,
								   GEA_City, city.m_id,
								   GEA_End);
	ChangeSpecialists(POP_SLAVE, +1);
					}
	} else {
		for(i = count; i < 0; i++) {
		}
	}

		sint32 delta_martial_law;
	CityData *cd = city.GetData()->GetCityData();
	cd->GetHappy()->CalcHappiness(*cd, FALSE, delta_martial_law, TRUE);

	return SFN_ERROR_OK;
}

	12-01-2005 06:27									#25
	Support Apolyton buy from Amazon

is there a function

GetTileOwner
and
ChangeTileOwner?

I was looking to have the ability to change ownership of territory once a unit fortifies (and cause war if it changes from one player to another)

Could this code in cell.cpp be reference for it?

code:

void Cell::SetOwner(sint32 owner)
{
	
	m_playerLandArea[m_cellOwner+1]--;
	m_cellOwner = (sint8)owner;
	m_playerLandArea[m_cellOwner+1]++;
}

Last edited by E on 12-01-2005 at 21:41

	12-01-2005 20:26									#26
	Increase Your PM Length

quote: Originally posted by E PlayerReceivesTradedGood function? PlayerSendstradedGood function?

Actual this doesn't seem to make sense, according to the names of these functions they can only act when a good is send. And that is covered by the SendGood event. It has three arguments the first an integer an index into the good's database and the second the sender city and the third the receiver city. From the cities you can retrieve the owner.

quote: Originally posted by E as for the new code, do we need to type something like this? code: int_t TradeRoutes(location_t) { sint32 p; if(args->m_numArgs != 1) return SFN_ERROR_NUM_ARGS; if(!args->GetPlayer(0, p)) return SFN_ERROR_TYPE_ARGS; m_result.m_int = g_player[p]->TradeRoutes(); return SFN_ERROR_OK; }

Not quite. At first I gave the here the slic function signature I would expect in fact in the documentation I find something like this:

INT PlayerCityCount(player)

Actual I would now write it like:

INT PlayerCityCount(int_t player)

INT is the return type in this case an integer VOID would mean the function doesn't return anything. int_t is the type of the slic variable in this case it is of type int_t actual a whole number, and player is a description of the meaning of this variable, for simplicity I skipped the variable name in my function description. It isn't used anywhere anyway.

Now to add a new slic function you have to modify three files, slicfunc.cpp, SlicEngine.cpp and SlicFunc.h, note that on a Linux machine in contrast to a windows machine slicfunc.cpp and SlicFunc.cpp are different files. I don't tell you now in which directory you can find these files as you already should have found these files. By the way these files are the same files Solver modified to add the IsOnSameContinent.

To understand how to add such an function look in all these file for IsOnSameContinent or any other slic function.

Let's do a tutorial function and let's suppose we don't have a TradeRoutes already:

In SlicFunc.h we have a long list like this:

code:

SLICFUNC(SFR_INT, StringCompare)				
SLICFUNC(SFR_INT, CityNameCompare)				
SLICFUNC(SFR_VOID, ChangeGlobalRegard)			 

SLICFUNC(SFR_VOID, SetAllCitiesVisible)			
SLICFUNC(SFR_VOID, SetCityVisible)				


SLICFUNC(SFR_INT, IsCivilian)					

SLICFUNC(SFR_VOID, FinishImprovements)         
SLICFUNC(SFR_VOID, RemoveAdvance)              
SLICFUNC(SFR_INT, PlayerGold)                  
SLICFUNC(SFR_INT, GetArmyFromUnit)				
SLICFUNC (SFR_INT, ClearBattleFlag)				
SLICFUNC(SFR_VOID, MinimizeAction)				
SLICFUNC(SFR_INT, IsUnitAtHead)					
SLICFUNC(SFR_VOID, OpenScenarioEditor)

	12-01-2005 20:59									#27
	Support Apolyton buy from Amazon

:wow: thanks Martin! I'm sure I'll have to go over it a few times, especially since my only experience is with turbopascal and that was several years ago.

But just a quick question, how do I get the progam to find certain variables. I'm thinking this applies to the m_int thinkgy part you mention. Is there somewhere I can check for a list of usable variables?

Will it recognize a GetFood or GetScienceProducion? stuff like that or do I have to create those functions by digging through other parts of the code and see how the code already tries and gets those values?

	12-01-2005 21:20									#28
	Support Apolyton, buy Civilization: The Boardgame

quote: Originally posted by E But just a quick question, how do I get the progam to find certain variables. I'm thinking this applies to the m_int thinkgy part you mention. Is there somewhere I can check for a list of usable variables?

I think to answer that question in detail I have to start a C++ lecture for beginners. But I would break the topic then in much more smaller pieces like this one.

quote: Originally posted by E Will it recognize a GetFood or GetScienceProducion? stuff like that or do I have to create those functions by digging through other parts of the code and see how the code already tries and gets those values?

You mean something like:

cell->GetFood()

Well you have check whether there is such a function in the Cell class and use function it. Of course most of them is already in the program.

-Martin

	12-01-2005 21:40									#29
	Support Apolyton, buy Galactic Civilizations: Deluxe Edition

I found this in cell.cpp

code:


sint32 Cell::GetFoodProduced() const 
{
	sint32 food = GetFoodFromTerrain();
	sint32 i;
	for(i = m_objects->Num() - 1; i >= 0; i--) {
		if((m_objects->Access(i).m_id & k_ID_TYPE_MASK) == k_BIT_GAME_OBJ_TYPE_IMPROVEMENT_DB) {
			const TerrainImprovementRecord *impRec = 
				g_theTerrainImprovementDB->Get(m_objects->Access(i).m_id & k_ID_KEY_MASK);
			const TerrainImprovementRecord::Effect *effect;
			effect = terrainutil_GetTerrainEffect(impRec, m_terrain_type);
			sint32 bonus;
			if(effect && effect->GetBonusFood(bonus)) {
				food += bonus;
			}
		}
	}																					
																					
    return food;

	13-01-2005 16:44									#30
	Support Apolyton, buy Civilization 2

quote: Originally posted by E I found this in cell.cpp

And that's probably the function you were looking for.

quote: Originally posted by E I hoping I'm lookingin the right place, but what is the file unseenCell.cpp used for?

Of course what it says for the unseen Cells the tiles you don't see. With my latest vision update, now always such an unseen cell object is created, in order to store the information that is needed to disply the stuff from your last visit on the status bar and the help tile window. Each player has such unseen cells for each cell he does not see on the map.

-Martin